Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more Pixel tracks SoA monitoring #40457

Merged
merged 2 commits into from
Jan 13, 2023

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Jan 9, 2023

PR description:

The goal of this PR is two-fold:

  • add more monitoring histograms for SoA Tracks (done in commit 218cbd4)
  • add 1D projections of the 2D scatter plot histograms of GPU vs CPU quantities for selected variables (done in commit 6a143cc).

PR validation:

Run successfully: runTheMatrix.py -l 21034.507, 20834.507 -t 4 -j 8 --ibeos

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

N/A

@mmusich
Copy link
Contributor Author

mmusich commented Jan 9, 2023

test parameters:

  • enable_tests = gpu
  • workflows_gpu = 21034.507, 20834.507
  • relvals_opt= -w upgrade
  • relvals_opt_gpu = -w upgrade

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 9, 2023

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40457/33614

  • This PR adds an extra 16KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 9, 2023

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40457/33615

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 9, 2023

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

  • DQM/SiPixelHeterogeneous (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @syuvivida, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@idebruyn, @threus, @fioriNTU, @hdelanno, @jandrea this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Jan 9, 2023

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 9, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d932c2/29843/summary.html
COMMIT: a5ed9b2
CMSSW: CMSSW_13_0_X_2023-01-09-1100/el8_amd64_gcc11
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40457/29843/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 13 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3555538
  • DQMHistoTests: Total failures: 160
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3555356
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 211 log files, 162 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

GPU Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 6
  • DQMHistoTests: Total histograms compared: 130192
  • DQMHistoTests: Total failures: 23
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 130169
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 10.536 KiB( 5 files compared)
  • DQMHistoSizes: changed ( 20834.507 ): 10.536 KiB SiPixelHeterogeneous/PixelTrackCompareGPUvsCPU
  • Checked 20 log files, 16 edm output root files, 6 DQM output files
  • TriggerResults: no differences found

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40457/33635

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

Pull request #40457 was updated. @emanueleusai, @ahmad3213, @cmsbuild, @syuvivida, @pmandrik, @micsucmed, @rvenditti can you please check and sign again.

@mmusich
Copy link
Contributor Author

mmusich commented Jan 10, 2023

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d932c2/29878/summary.html
COMMIT: 4131dcc
CMSSW: CMSSW_13_0_X_2023-01-09-2300/el8_amd64_gcc11
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40457/29878/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3555538
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3555516
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 211 log files, 162 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

GPU Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 16 differences found in the comparisons
  • DQMHistoTests: Total files compared: 6
  • DQMHistoTests: Total histograms compared: 130192
  • DQMHistoTests: Total failures: 4067
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 126125
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 10.536 KiB( 5 files compared)
  • DQMHistoSizes: changed ( 20834.507 ): 10.536 KiB SiPixelHeterogeneous/PixelTrackCompareGPUvsCPU
  • Checked 20 log files, 16 edm output root files, 6 DQM output files
  • TriggerResults: no differences found

@mmusich
Copy link
Contributor Author

mmusich commented Jan 10, 2023

@cms-sw/dqm-l2 it would be good to have this integrated prior to start testing #40465.
Do you have any objections to sign it?

@rappoccio
Copy link
Contributor

@cms-sw/dqm-l2 ping on this one as well

@emanueleusai
Copy link
Member

+1

  • adds new plots

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 30f2c50 into cms-sw:master Jan 13, 2023
@mmusich mmusich deleted the addMorePixelTracksSoAMonitoring branch January 13, 2023 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants